Replace govaluate with expr for expression evaluation#1686
Open
Replace govaluate with expr for expression evaluation#1686
Conversation
|
|
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
…operator conversion to eval function Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Switch from govaluate to expr library
Replace govaluate with expr for expression evaluation
Jan 13, 2026
Contributor
|
@copilot fix: |
…comments Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Contributor
Author
... Fixed in commit 25e24a4:
All linting issues should now be resolved. |
Contributor
|
@copilot fix: |
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Contributor
Author
... Fixed in commit b1b2782. The issue was an extra blank line between third-party imports. According to goimports, all third-party imports should be grouped together without blank lines separating them. |
Contributor
|
@copilot fix: |
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Contributor
Author
... Fixed in commit 322d864. The goimports convention for this repo requires external third-party packages (expr-lang) to be in a separate group from internal casbin packages, with a blank line separating them. |
Benchmark ComparisonComparing base branch ( 🤖 This comment will be automatically updated with the latest benchmark results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration from govaluate to expr - COMPLETE
Summary
Successfully migrated from govaluate to expr library with full backward compatibility. All existing tests pass, ABAC/RBAC models work correctly, and the migration includes automatic syntax conversion for compatibility.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.